Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Dec 2002 20:21:03 +0000
From:      Josef Karthauser <joe@FreeBSD.org>
To:        Nate Lawson <nate@root.org>
Cc:        cvs-all@freebsd.org, cvs-committers@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/usb ohci.c
Message-ID:  <20021209202103.GA658@genius.tao.org.uk>
In-Reply-To: <Pine.BSF.4.21.0212091149270.25027-100000@root.org>
References:  <20021209014609.9F72F37B50C@hub.freebsd.org> <Pine.BSF.4.21.0212091149270.25027-100000@root.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Mon, Dec 09, 2002 at 11:58:09AM -0800, Nate Lawson wrote:
> On Sun, 8 Dec 2002, Josef Karthauser wrote:
> > joe         2002/12/08 17:41:24 PST
> > 
> >   Modified files:
> >     sys/dev/usb          ohci.c 
> >   Log:
> >   MFNetBSD: (partial 1.133)
> >   - In ohci_close_pipe, wait 1ms after removing an ED to avoid possible race
> >     condition.
> >   
> >   Approved by:    re (rwatson)
> 
> Wouldn't it be better to use a mtx or tsleep/wakeup?  A delay leaves the
> race, only making it non-deterministic.
> 

Probably, got a patch :)?

Joe
-- 
Josef Karthauser (joe@tao.org.uk)	       http://www.josef-k.net/
FreeBSD (cvs meister, admin and hacker)     http://www.uk.FreeBSD.org/
Physics Particle Theory (student)   http://www.pact.cpes.sussex.ac.uk/
================ An eclectic mix of fact and theory. =================

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iEYEARECAAYFAj30+y4ACgkQXVIcjOaxUBZHpgCdG9hDet+0YOrGoEzKTuZk9fDe
EWoAoIW9i7OIBdDVV16YBLCRIsdADVXc
=ykaT
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021209202103.GA658>