Date: Mon, 14 Aug 2006 16:43:13 GMT From: Roman Divacky <rdivacky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 103865 for review Message-ID: <200608141643.k7EGhDRh099416@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=103865 Change 103865 by rdivacky@rdivacky_witten on 2006/08/14 16:42:53 A few more comments. Affected files ... .. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_emul.c#5 edit .. //depot/projects/soc2006/rdivacky_linuxolator/i386/linux/linux_machdep.c#50 edit Differences ... ==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_emul.c#5 (text+ko) ==== @@ -190,6 +190,9 @@ cup.uaddr2 = NULL; cup.val3 = 0; error = linux_sys_futex(FIRST_THREAD_IN_PROC(p), &cup); + /* this cannot happen at the moment and if this happens + * it probably mean there is a userspace bug + */ if (error) printf(LMSG("futex stuff in proc_exit failed.\n")); } ==== //depot/projects/soc2006/rdivacky_linuxolator/i386/linux/linux_machdep.c#50 (text+ko) ==== @@ -412,6 +412,9 @@ } if (args->flags & CLONE_THREAD) { + /* XXX: linux mangles pgrp and pptr somehow + * I think it might be this but I am not sure. + */ #ifdef notyet p2->p_pgrp = td->td_proc->p_pgrp; p2->p_pptr = td->td_proc->p_pptr;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608141643.k7EGhDRh099416>