Date: Wed, 03 Nov 2004 09:48:41 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: scottl@FreeBSD.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c Message-ID: <20041103.094841.89130476.imp@bsdimp.com> In-Reply-To: <418905E5.1050605@freebsd.org> References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <418905E5.1050605@freebsd.org> Scott Long <scottl@FreeBSD.org> writes: : Poul-Henning Kamp wrote: : > phk 2004-11-03 14:11:18 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/em if_em.c : > Log: : > Put the "Link is up/down" printfs behind bootverbose. gigE is not so uncommon : > that we need to tell people about every cable in the network anymore. It can : > be enabled for debugging purposes with "boot -v". : > : > Revision Changes Path : > 1.51 +8 -6 src/sys/dev/em/if_em.c : : I think that in general we can start eyeing a lot of similar verbosity : in all of our drivers, both at boot and at runtime. For example most : nic drivers print out their MAC and all of their possible negotiation : rates on attach. This same info can be obtained from ifconfig. Why : clutter the boot with it? Well, you can't get all the info you need from ifconfig. If you want to know WHICH nic is in WHAT slot, it is a lot easier to get that from the one liner printed on boot (especially when trying to troubleshoot things) than to get it from ifconfig + dmesg. I think that's useful to continue to have there. I do agree that the rate thing of the wireless drivers is excessive, as is many of the rate things. fwohci likely can use some trimming as well, even in the non-verbose mode. The CAM messages are the only messages in FreeBSD more verbose than VMS :-) Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041103.094841.89130476.imp>