Date: Fri, 21 Feb 2003 16:10:21 -0800 (PST) From: Nate Lawson <nate@root.org> To: Maxime Henrion <mux@freebsd.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <Pine.BSF.4.21.0302211608570.54211-100000@root.org> In-Reply-To: <20030221235701.GS60813@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 22 Feb 2003, Maxime Henrion wrote: > Nate Lawson wrote: > > But I don't care either way -- I try to stick to the original style when > > possible (i.e. the xl changes do not remove the goto tree even though I > > don't like that style). > > Then let's follow the existing style in those drivers. I will. > > I actually did that on purpose to handle future reordering if it > > happens. I think it's an advantage to have the resource cleanup be > > (mostly) independent of the order it was allocated in. In fact, with > > a little more work, the attach error case and the detach case could be > > unified. > > Fair enough. It would be nice to add a comment explaining this then so > that people don't wonder about it. Also, telling it to lint with a > /* UNREACH */ or something might make sense. Ok. > Why aren't you doing it in every driver? Shhhh. You know how to boil a frog, right? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0302211608570.54211-100000>