Date: Tue, 15 Mar 2016 07:16:41 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296769 - in head/sys/boot/efi: boot1 loader Message-ID: <20160315061641.GI11339@ivaldir.etoilebsd.net> In-Reply-To: <201603122144.u2CLiXv5023698@repo.freebsd.org> References: <201603122144.u2CLiXv5023698@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, Mar 12, 2016 at 09:44:33PM +0000, Ed Maste wrote: > Author: emaste > Date: Sat Mar 12 21:44:33 2016 > New Revision: 296769 > URL: https://svnweb.freebsd.org/changeset/base/296769 > > Log: > boot/efi: Prefer nm to objdump > > Both objdump and nm are equally capable of reporting undefined symbols. > > This gets us a step closer to building without binutils as we have an nm > implementation from ELF Tool Chain. > > Reviewed by: bdrewery > MFC after: 1 month > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D5613 > > Modified: > head/sys/boot/efi/boot1/Makefile > head/sys/boot/efi/loader/Makefile > > Modified: head/sys/boot/efi/boot1/Makefile > ============================================================================== > --- head/sys/boot/efi/boot1/Makefile Sat Mar 12 20:05:23 2016 (r296768) > +++ head/sys/boot/efi/boot1/Makefile Sat Mar 12 21:44:33 2016 (r296769) > @@ -73,8 +73,8 @@ LDADD+= -lstand > > DPADD+= ${LDSCRIPT} > > +NM?= nm > OBJCOPY?= objcopy > -OBJDUMP?= objdump > > .if ${MACHINE_CPUARCH} == "amd64" > EFI_TARGET= efi-app-x86_64 > @@ -85,8 +85,8 @@ EFI_TARGET= binary > .endif > > boot1.efi: ${PROG} > - if [ `${OBJDUMP} -t ${.ALLSRC} | fgrep '*UND*' | wc -l` != 0 ]; then \ > - ${OBJDUMP} -t ${.ALLSRC} | fgrep '*UND*'; \ > + if ${NM} ${.ALLSRC} | grep ' U '; then \ grep -q maybe to avoid extra noise? Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW56i0AAoJEGOJi9zxtz5a+uQQAKNpUwDXswYgeQn0fJBmMRNW 3a2HRkBbDkmFsndjR8+dFqggdu+mVd7DdnKW9J4lwUfreh2eTh82Axh+fQgncOH5 NMke9mcPeUiKIYyidGxSgFOonMoBsToWofPr0l3lsb7MS8zBLbCmz6u/nrnxHJwD vKR1cJ4P9HEII6IK1vGuA57BPfJMtLKM0wkpLwgc+EP4CZlZqkbgsCmutXPeGCNi pru3jI75XbXEcGUws99YJH7xEBF2gJbuyDgQ5nm5RQbMME6d9FxNIP6dFMzd2yaH jkFXYbcyHZWtP+9q4cgWb3rGkCUQVM2tbfepZTnMbgfjaI/7OWXLjbtr9E8DgPiN wrox/kR+zCRvbwdcP3PYMHyFwas+7bjYo7LwNVXCVzg4tNno4Ti56Jr/vL8g84TH 0KfMCDZKCkn76asAHMPScmYRn+JQyq4MIlf6NmZDXt1vNbVo0bJ2gkhOBUkFfObs FrXoWkvdnIlqfTrwGK1tVDY0AbqqMAGzEfukRi8f9GzYx+pqmPzz1qVF/OeS3WSK ci/BqaBNL86u4VXJzcsXTC5T4qfkhNE3yWrg7z/hZHMsrnCrHplOY2q9uQKMpd4/ Jmsa6OhubtNiGSFeSDrm1hHuws26OkJRK5darfB+Uuk39nOJPbbORiDCdNPPfZRs XrTTjrTFIt4Y0MHf7xoC =8tXk -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160315061641.GI11339>