Date: Wed, 09 Feb 2022 11:08:44 +0100 From: Kristof Provost <kp@FreeBSD.org> To: Gary Jennejohn <gljennjohn@gmail.com> Cc: current@freebsd.org Subject: Re: test-includes breaks buildworld when WITHOUT_PF is set in src.conf Message-ID: <7E81E26A-1296-4107-8379-53A9F2C0DCE6@FreeBSD.org> In-Reply-To: <20220209105752.2c382ac2@ernst.home> References: <20220209105752.2c382ac2@ernst.home>
index | next in thread | previous in thread | raw e-mail
On 9 Feb 2022, at 10:57, Gary Jennejohn wrote:
> test-includes uses pf.h when checking usage of pfvar.h.
>
> But, these lines in include/Makefile remove pf.h when WITHOUT_PF is
> set in src.conf:
>
> .if ${MK_PF} != "no"
> INCSGROUPS+= PF
> .endif
>
> This breaks buildworld. The error message:
>
> In file included from net_pfvar.c:1:
> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/net/pfvar.h:65:10: fatal error:
> 'netpfil/pf/pf.h' file not found
> #include <netpfil/pf/pf.h>
> ^~~~~~~~~~~~~~~~~
> 1 error generated.
> --- net_pfvar.o ---
> *** [net_pfvar.o] Error code 1
>
> make[3]: stopped in /usr/src/tools/build/test-includes
> .ERROR_TARGET='net_pfvar.o'
>
> Removing the .if/.endif fixes it for me, although there may be a better
> way to avoid the error.
>
Warner’s working on a better fix. See https://reviews.freebsd.org/D34009 for the discussion.
Kristof
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7E81E26A-1296-4107-8379-53A9F2C0DCE6>