Date: Thu, 2 Nov 2017 20:50:10 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, freebsd-hackers <freebsd-hackers@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Head build unsafe for /etc today Message-ID: <20171103035010.GA89291@troutmask.apl.washington.edu> In-Reply-To: <998FF503-D4B0-4AD5-AD55-98680E4D66CA@FreeBSD.org> References: <3045EEBF-09E6-4209-B54F-2F95394DBA82@FreeBSD.org> <20171103014907.GA88522@troutmask.apl.washington.edu> <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org> <20171103022327.GA88659@troutmask.apl.washington.edu> <998FF503-D4B0-4AD5-AD55-98680E4D66CA@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 02, 2017 at 07:41:21PM -0700, Bryan Drewery wrote: > > Are you accusing me of lying? > Nope. I'm stating the obvious. If you are using META_MODE and you do "make buildwould" that is equivalent to "make -DNO_CLEAN buildworld", which means you did not rebuild the *world*. When I see a commit message of the form (and I've haven't seen one like this in 25+ years of using FreeBSD (aka 386BSD+patchkit)) Author: bdrewery Date: Thu Nov 2 22:23:00 2017 New Revision: 325347 URL: https://svnweb.freebsd.org/changeset/base/325347 Log: Something is very wrong Modified: head/Makefile Modified: head/Makefile ============================================================================== --- head/Makefile Thu Nov 2 21:58:18 2017 (r325346) +++ head/Makefile Thu Nov 2 22:23:00 2017 (r325347) @@ -1,3 +1,4 @@ +.error Bad revision, please wait for a fix in head It suggests that whomever did the commit did not properly test the patch. The use of META_MODE (or any other shortcut) when testing simply isn't proper testing. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171103035010.GA89291>