Date: Sun, 4 Mar 2018 02:04:29 -0800 From: Eitan Adler <lists@eitanadler.com> To: "Pedro F. Giffuni" <pfg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r320579 - head/usr.bin/patch Message-ID: <CAF6rxgm0%2BaEQLo-JMebcjiW4hyeahCeFzHVwbAp5w%2BT96ZQnqg@mail.gmail.com> In-Reply-To: <201707022100.v62L0Ume001253@repo.freebsd.org> References: <201707022100.v62L0Ume001253@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2 July 2017 at 14:00, Pedro F. Giffuni <pfg@freebsd.org> wrote:
> + } else if (strnEQ(s, "diff --git a/", 13)) {
> + /* Git-style diffs. */
> + piece_of_git = 1;
This is incomplete and leaves to confusing behavior for some git
diffs. In particular with 'diff.mnemonicprefix = true' the prefix is
awesome something other than 'a/'. It can be 'w' for working copy, 'i'
for index, 'c' for commit, or some other values.
While I don't oppose this feature, it'd be better if we did not tie it
to a single specific prefix.
--
Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgm0%2BaEQLo-JMebcjiW4hyeahCeFzHVwbAp5w%2BT96ZQnqg>