Date: Wed, 14 Apr 2010 22:02:19 +0000 (UTC) From: Xin LI <delphij@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sbin/ifconfig ifconfig.c src/share/man/man4 netintro.4 src/sys/net if.c Message-ID: <201004142207.o3EM7g7L006741@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
delphij 2010-04-14 22:02:19 UTC FreeBSD src repository Modified files: sbin/ifconfig ifconfig.c share/man/man4 netintro.4 sys/net if.c Log: SVN rev 206637 on 2010-04-14 22:02:19Z by delphij When an underlying ioctl(2) handler returns an error, our ioctl(2) interface considers that it hits a fatal error, and will not copyout the request structure back for _IOW and _IOWR ioctls, keeping them untouched. The previous implementation of the SIOCGIFDESCR ioctl intends to feed the buffer length back to userland. However, if we return an error, the feedback would be defeated and ifconfig(8) would trap into an infinite loop. This commit changes SIOCGIFDESCR to set buffer field to NULL to indicate the previous ENAMETOOLONG case. Reported by: bschmidt MFC after: 2 weeks Revision Changes Path 1.153 +12 -11 src/sbin/ifconfig/ifconfig.c 1.29 +6 -3 src/share/man/man4/netintro.4 1.381 +3 -4 src/sys/net/if.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004142207.o3EM7g7L006741>