Date: Tue, 3 Mar 2009 18:47:33 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/netgraph ng_pppoe.c ng_pppoe.h src/sys/netgraph/atm ng_ccatm.h Message-ID: <200903031849.n23InsKH002761@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ed 2009-03-03 18:47:33 UTC
FreeBSD src repository
Modified files:
sys/netgraph ng_pppoe.c ng_pppoe.h
sys/netgraph/atm ng_ccatm.h
Log:
SVN rev 189315 on 2009-03-03 18:47:33Z by ed
Make Netgraph compile with Clang.
Clang disallows structs with variable length arrays to be nested inside
other structs, because this is in violation with ISO C99. Even though we
can keep bugging the LLVM folks about this issue, we'd better just fix
our code to not do this. This code seems to be the only code in the
entire source tree that does this.
I haven't tested this patch by using the kernel modules in question, but
Diane Bruce and I have compared disassembled versions of these kernel
modules. We would have expected them to be exactly the same, but due to
randomness in the register allocator and reordering of instructions,
there were some minor differences.
Approved by: julian
Revision Changes Path
1.3 +0 -1 src/sys/netgraph/atm/ng_ccatm.h
1.95 +12 -11 src/sys/netgraph/ng_pppoe.c
1.26 +0 -2 src/sys/netgraph/ng_pppoe.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903031849.n23InsKH002761>