Date: Tue, 28 Jul 2015 15:23:16 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Ed Schouten <ed@nuxi.nl> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r285926 - in head: libexec/ypxfr usr.bin/ypcat usr.bin/ypmatch usr.bin/ypwhich usr.sbin/yp_mkdb usr.sbin/yppush usr.sbin/ypserv Message-ID: <CAOfEmZgHBphMd-maSvCkE33-Ma-G_GPP%2B_fqFHw3TKju%2BW9Uaw@mail.gmail.com> In-Reply-To: <CABh_MKmssa3h8MKJawKj_thECxGwCa9cLd5fcwL035_5GHtomw@mail.gmail.com> References: <201507280232.t6S2WfSq043383@repo.freebsd.org> <CABh_MKmssa3h8MKJawKj_thECxGwCa9cLd5fcwL035_5GHtomw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2015-07-28 15:05 GMT+08:00 Ed Schouten <ed@nuxi.nl>:
> Hi Marcelo,
>
> Thanks for working on this!
>
> 2015-07-28 4:32 GMT+02:00 Marcelo Araujo <araujo@freebsd.org>:
> > -struct ypalias {
> > +const struct ypalias {
> > char *alias, *name;
> > -} ypaliases[] = {
> > +} static ypaliases[] = {
> > { "passwd", "passwd.byname" },
> > { "master.passwd", "master.passwd.byname" },
> > { "shadow", "shadow.byname" },
>
> I seem to remember that certain compilers (Intel?) are pretty picky
> about the ordering of 'static' and 'const'.
>
> const static int i; // Compiler error.
>
> It's also inconsistent with the rest of our codebase, where we
> typically put 'static' in front of the type. Could you please change
> this to the following?
>
> static const struct ypalias {
> ...
> } ypaliases[] = {
> ...
> };
>
> Thanks!
>
Hello Ed,
Thanks to point it out. I got a problem with sparc64, exactly because of
that.
I will fix it later.
All the best.
--
Marcelo Araujo (__)araujo@FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^
Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZgHBphMd-maSvCkE33-Ma-G_GPP%2B_fqFHw3TKju%2BW9Uaw>