Date: Tue, 22 Nov 2005 21:34:26 +0000 (UTC) From: Marius Strobl <marius@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/sparc64/pci psycho.c psychoreg.h psychovar.h Message-ID: <200511222134.jAMLYQAp085077@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
marius 2005-11-22 21:34:26 UTC
FreeBSD src repository
Modified files:
sys/sparc64/pci psycho.c psychoreg.h psychovar.h
Log:
Some clean-up, style changes and changes that will reduce differences
between this driver and other Host-PCI bridge drivers based on this one:
- Make the code fit into 80 columns.
- Make the code adhere style(9) (don't use function calls in initializers,
use uintXX_t instead of u_intXX_t, add missing prototypes, ...).
- Remove unused and superfluous struct declaration, softc member, casts,
includes, etc.
- Use FBSDID.
- Sprinkle const.
- Try to make comments and messages consistent in style throughout the
driver.
- Use convenience macros for the number of interrupts and ranges of the
bridge.
- Use __func__ instead of hardcoded function names in panic strings and
error messages. Some of the hardcoded function names actually were
outdated through moving code around. [1]
- Rename softc members related to the PCI side of the bridge to sc_pci_*
in order to make it clear which side of the bridge they refer to (so
stuff like sc_bushandle vs. sc_bh is less confusing while reading the
code).
PR: 76052 [1]
Revision Changes Path
1.54 +192 -197 src/sys/sparc64/pci/psycho.c
1.10 +34 -31 src/sys/sparc64/pci/psychoreg.h
1.13 +17 -18 src/sys/sparc64/pci/psychovar.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511222134.jAMLYQAp085077>