Skip site navigation (1)Skip section navigation (2)
Date:      20 Jun 2000 20:10:36 +0200
From:      Dag-Erling Smorgrav <des@flood.ping.uio.no>
To:        Wes Peters <wes@softweyr.com>
Cc:        Wes Peters <wes@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libfetch ftp.c
Message-ID:  <xzpitv4rzoj.fsf@flood.ping.uio.no>
In-Reply-To: Wes Peters's message of "Tue, 20 Jun 2000 09:39:30 -0600"
References:  <200006200532.WAA11992@freefall.freebsd.org> <xzp66r4tq4z.fsf@flood.ping.uio.no> <394F9032.2123D32B@softweyr.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Wes Peters <wes@softweyr.com> writes:
> Dag-Erling Smorgrav wrote:
> > Wes Peters <wes@FreeBSD.org> writes:
> > >   Reviewed by:        silence
> > Bollocks. Libfetch is under active development, and the fact that I
> > haven't committed anything in three weeks doesn't mean it's abandoned.
> When I contacted you five weeks ago, you agreed to review.  Would you
> like me to forward the email?

I did not agree to review it, I agreed to consider it for inclusion in
my code. A quick inspection showed that it duplicated significant
portions of fetchStatFTP(), and I decided not to commit it as-is but
to separate the relevant parts from fetchStatFTP() so they could be
shared by both fetchStatFTP() and fetchListFTP(). I then set it aside
since I was busy working on the HTTP code and the pkg_install patches.

What's more, you made no further attempt to contact me after having
submitted your patch, and construed my silence as approval even though
you should have known (from mail I sent to -chat and -committers) that
I was cut off from FreeBSD work due to an sshd misconfiguration.

DES
-- 
Dag-Erling Smorgrav - des@flood.ping.uio.no


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpitv4rzoj.fsf>