Date: Sun, 5 Aug 2012 14:50:34 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r239071 - head/usr.bin/make Message-ID: <20120805215034.GA50893@troutmask.apl.washington.edu> In-Reply-To: <201208051555.q75Ftbaa099801@svn.freebsd.org> References: <201208051555.q75Ftbaa099801@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 05, 2012 at 03:55:37PM +0000, Dimitry Andric wrote: > Author: dim > Date: Sun Aug 5 15:55:36 2012 > New Revision: 239071 > URL: http://svn.freebsd.org/changeset/base/239071 > > Log: > In usr.bin/make/var.c, function ParseModifier(), initialize the 'error' > variable to NULL, to avoid using it uninitialized in certain cases. > > This fixes the following clang 3.2 warning: > > usr.bin/make/var.c:1770:10: error: variable 'error' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > if (vp->execute) { > ^~~~~~~~~~~ Please wrap your commit messages to less than 80 characters. In fact, including the clang warning does not add any valuable information and should be omitted. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120805215034.GA50893>