Date: Mon, 08 Jul 2002 15:27:56 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Peter Wemm <peter@wemm.org> Cc: current@freebsd.org Subject: RE: Remember my ill-fated i386 smp pmap optimizations? Message-ID: <XFMail.20020708152756.jhb@FreeBSD.org> In-Reply-To: <20020708062855.02DE03808@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08-Jul-2002 Peter Wemm wrote:
> A few months ago, I had a bit of a disaster with some pmap optimizations.
> After committing, all hell broke loose. It was backed out completely.
>
> I finally found the problem (diff cleaned up to highlight the problem):
>
> pmap_mapdev()
> ...
> for (tmpva = va; size > 0; ) {
> pte = vtopte(tmpva);
> *pte = pa | PG_RW | PG_V | pgeflag;
> size -= PAGE_SIZE;
> tmpva += PAGE_SIZE;
> - pa += PAGE_SIZE;
> }
> invltlb();
>
> Excuse me while I go outside and shoot myself.
Hahahaha!
Glad to see you have fixed them. :)
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020708152756.jhb>