Date: Sun, 1 Nov 2009 16:15:18 +0000 From: "Robert N. M. Watson" <rwatson@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r198706 - head/sys/sys Message-ID: <D07678DD-D29E-4561-84AE-E969BE69BB42@FreeBSD.org> In-Reply-To: <20091101153339.GH1293@hoeg.nl> References: <200910311035.n9VAZfIb082932@svn.freebsd.org> <alpine.BSF.2.00.0911011506130.2930@fledge.watson.org> <20091101153339.GH1293@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1 Nov 2009, at 15:33, Ed Schouten wrote: > Because d_kind is a pointer, there will be a hole in the structure > of at > least 2 bytes (maybe even 6), which means we can safely extend > d_mode to > 32 bits as well. I could have decided to leave it at uint16_t, but > that > would only obfuscate it even more when we would try to reclaim some > space there. > > d_list is just two pointers, so I merged it with d_kind into an > array of > three pointers No, you're right, and I was mistaken, it seems fine on i386 and amd64. And, at least here, d_devs is at the same offset on both architectures. The only really "weird" architecture is arm, which I believe aligns char and short to 32-bit, but that should be OK here I think as well. Robert
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D07678DD-D29E-4561-84AE-E969BE69BB42>