Date: Sun, 12 Oct 1997 22:38:14 +0200 From: j@uriah.heep.sax.de (J Wunsch) To: volf@oasis.IAEhv.nl (Frank Volf) Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: bin/4303 Message-ID: <19971012223814.MI27564@uriah.heep.sax.de> In-Reply-To: <199710121523.PAA07458@oasis.IAEhv.nl>; from Frank Volf on Oct 12, 1997 17:23:25 %2B0200 References: <199710121359.GAA06950@freefall.freebsd.org> <199710121523.PAA07458@oasis.IAEhv.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
As Frank Volf wrote: > I completely disagree: if I set dumpon to a non swap device by accident, > (for example /dev/rsd0s1e) I could/will lose part of my file system. dumpon should perhaps issue a warning if the device looks like something that has a filesystem on it. It should refuse to dump to any device that was opened by the time the dump happens. > But that is not the point. In kern_shutdown.c the following code can be > found (arround line 320 in function dumpsys): > > if ((minor(dumpdev)&07) != 1) > return; This used to be an (undocumented) feature, but turned into a bug over time. A device with (minor & 07) == 1 is no longer something very special. Swapping could have happened to anything else, nor would it make much sense that you could dump to /dev/rfd0.1720 but not to any other floppy device. ;-) Let alone tape drives... > Please, reconsider the close on this ticket. Well, i didn't say that everything is OK with the current behaviour either: it's only that i don't think we should restrict it to swap partions only. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19971012223814.MI27564>