Date: Mon, 7 Jul 2025 22:36:35 +0200 From: "Herbert J. Skuhra" <herbert@gojira.at> To: Dima Panov <fluffy@freebsd.org> Cc: Cy Schubert <cy@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7e35117eb07f - main - Makefile: Hook MIT KRB5 into the build Message-ID: <aGwv06rGlgW8zmJI@mail.bsd4all.net> In-Reply-To: <ea078103-ece6-4f00-af38-ec5688bef7db@FreeBSD.org> References: <202506160251.55G2pwx4063231@gitrepo.freebsd.org> <cc9222b0-8745-48cf-988c-4206287a7a7b@FreeBSD.org> <20250620073050.7f03f74e@slippy> <ea078103-ece6-4f00-af38-ec5688bef7db@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 07, 2025 at 10:36:31PM +0300, Dima Panov wrote:
> Hello!
>
>
> BTW, it looks like symlink for libkadm5clnt.so is broken and produced a bad file
> $ ls -la libkadm5clnt
> lrwxr-xr-x 1 root wheel 13 7 Jul 20:40 libkadm5clnt -> kadm5clnt_mit
>
> instead of assumed libkadm5clnt.so -> kadm5clnt_mit.so
>
>
> Please review:
>
> diff --git a/krb5/lib/kadm5clnt/Makefile b/krb5/lib/kadm5clnt/Makefile
> index e377f95f5b6e..be09dd3e210e 100644
> --- a/krb5/lib/kadm5clnt/Makefile
> +++ b/krb5/lib/kadm5clnt/Makefile
> @@ -88,7 +88,7 @@ ${CHPASS_UTIL_STRINGS_ERR_C}: ${CHPASS_UTIL_STRINGS_ERR}
> rm -f et-c-${.PREFIX}.et et-c-${.PREFIX}.c
>
> afterinstall:
> - ${INSTALL_LIBSYMLINK} ${SHLIB} ${DESTDIR}${LIBDIR}/libkadm5clnt
> + ${INSTALL_LIBSYMLINK} ${SHLIB_NAME} ${DESTDIR}${LIBDIR}/libkadm5clnt.so
>
> .include <bsd.lib.mk>
This produces a valid symlink that 'make delete-old' wants to
remove again:
lrwxr-xr-x 1 root wheel 23 Jul 7 22:26 /usr/lib/libkadm5clnt.so ->
libkadm5clnt_mit.so.121
# make delete-old
>>> Removing old files (only deletes safe to delete libs)
remove /usr/lib/libkadm5clnt.so?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aGwv06rGlgW8zmJI>