Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Jun 2021 17:59:47 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Warner Losh <imp@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 3f197b101f71 - main - release: Remove C-like string comparison operator
Message-ID:  <YNyxE9nM/g4VaPsi@FreeBSD.org>
In-Reply-To: <202106301720.15UHKkUQ079377@gitrepo.freebsd.org>
References:  <202106301720.15UHKkUQ079377@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 30, 2021 at 05:20:46PM +0000, Warner Losh wrote:
> commit 3f197b101f71ee4f4949c53bf330f61b43749ce9
> 
>     release: Remove C-like string comparison operator
>     
>     Per [(1), i.e. test(1), the string comparison operator should be `=`,
>     not `==` in sh(1) scripts.
>     
>     No functional change. FreeBSD's test accepts `==` as an alias for `=`
>     for compatibility with gnu test's `==` extension.

Nice, thanks, but why didn't you remove those needless quotes around
static stings, e.g. "GPT" -> GPT?

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YNyxE9nM/g4VaPsi>