Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Jan 1997 06:56:40 -0800 (PST)
From:      mark thompson <thompson@tgsoft.com>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   bin/2449: nit in ij-ppp
Message-ID:  <199701111456.GAA15414@squirrel.tgsoft.com>
Resent-Message-ID: <199701111500.HAA19917@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         2449
>Category:       bin
>Synopsis:       ij-ppp in auto mode goes into failure loop
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 11 07:00:01 PST 1997
>Last-Modified:
>Originator:     mark thompson
>Organization:
tgsoft
>Release:        FreeBSD 2.1-960627-SNAP i386
>Environment:

Using user-mode ppp in auto mode.

>Description:

If ppp ever gets to the line:
      LogPrintf(LOG_PHASE_BIT, "** 1 Too many ECHO packets are lost. **\n");
It will get there every time until killed, because the counter "lqrsendcnt"
does not get reset.

>How-To-Repeat:

Best way to reproduce this is to have the receiving end refuse to
anwer pings for a while, then bring it back.

>Fix:
	
diff -r -u ../FreeBSD.2.2/src/usr.sbin/ppp/lqr.c Root/usr/src/usr.sbin/ppp/lqr.c
--- ../FreeBSD.2.2/src/usr.sbin/ppp/lqr.c	Sat May 11 13:48:33 1996
+++ Root/usr/src/usr.sbin/ppp/lqr.c	Fri Jan 10 05:06:26 1997
@@ -189,6 +189,7 @@
   struct lcpstate *lcp = &LcpInfo;
   int period;
 
+  lqrsendcnt = 0;	/* start waiting all over for ECHOs */
   lqmmethod = LQM_ECHO;
   if (Enabled(ConfLqr))
     lqmmethod |= LQM_LQR;


>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701111456.GAA15414>