Date: Fri, 20 Nov 2009 08:46:48 +0100 From: Hans Petter Selasky <hselasky@freebsd.org> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 170842 for review Message-ID: <200911200846.54559.hselasky@freebsd.org> In-Reply-To: <4B05CB1F.8020100@freebsd.org> References: <200911192235.nAJMZ2XH072195@repoman.freebsd.org> <4B05CB1F.8020100@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 19 November 2009 23:47:59 Nathan Whitehorn wrote: > Hans Petter Selasky wrote: > > http://p4web.freebsd.org/chv.cgi?CH=170842 > > > > Change 170842 by hselasky@hselasky_laptop001 on 2009/11/19 22:34:49 > > > > > > USB input: > > - ATP patch from Rohit Grover: > > - fixes some minor issues and > > makes the control transfer > > fully asynchronous > > [...] > > > @@ -1530,7 +1574,7 @@ > > return (ENXIO); > > > > if (usbd_lookup_id_by_uaa(atp_devs, sizeof(atp_devs), uaa) == 0) > > - return BUS_PROBE_SPECIFIC; > > + return 0; > > else > > return ENXIO; > > } > > Why are you replacing symbolic constants with less informative numeric > ones? -Nathan Because returning zero in probe has special meaning and is hardcoded in the subr_bus.c code aswell. The other return values will not be changed. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911200846.54559.hselasky>