Date: Thu, 16 Oct 2014 17:39:48 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: araujo@FreeBSD.org Cc: freebsd-fs@freebsd.org Subject: Re: [PATCH] disable nfsd (NFSv4) nobody/nogroup check Message-ID: <997140144.720996.1413495588502.JavaMail.root@uoguelph.ca> In-Reply-To: <CAOfEmZjf-rLD6uYw-qCq7CiSNEDW4z6C_iF4zJT2p8_dRAFijg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcelo Araujo wrote: > > > > > > 2014-10-16 10:42 GMT+08:00 Marcelo Araujo < araujobsdport@gmail.com > > : > > > > > > > > 2014-10-16 7:46 GMT+08:00 Rick Macklem < rmacklem@uoguelph.ca > : > > > Marcelo Araujo wrote: > > > > Hello Ronald and Blot, > > > > > > > > Here is the patch with a small rework. I consider Ronaldo's > > comments > > as well as I just change a bit the code style. > > > > > > If you guys agree with the patch, I will commit it today. > > > Looks fine to me. > > > > Thanks Rick! Committed; I will do the MFC after two weeks if you have > no objections. > > > https://svnweb.freebsd.org/base?view=revision&revision=273159 > > > > > > > > Note: About the disable_utf8 that Rick has mention, I will rework > > that part later to make it as enable_utf8 instead of disable_utf8. > > > If you do change this one, try to include something in the > description > string w.r.t. RFC-3530 requires it to be enabled. > > Thanks, rick > > > > > > > Rick, here is a patch that renames the disable_utf8 to enable_utf8 > and as per your request, I have changed the description of the > sysctl(8) as well. > Let me know if the change looks good for you as well as the > description. > Looks fine to me, rick ps: I would suggest not MFC'ng this one, since I think it would be a POLA violation to have the sysctl name change. > > > > > > > > > > Ouch, I forgot to attach the patch, spotted by kevlo@ via Skype :_) > > > > > Best Regards, > > -- > > > > > -- > Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) > http://www.FreeBSD.org \/ \ ^ > Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?997140144.720996.1413495588502.JavaMail.root>