Date: Fri, 8 Jul 2005 20:48:44 -0400 From: Tom Rhodes <trhodes@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: rik@FreeBSD.org, scottl@samsco.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, sobomax@portaone.com, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c Message-ID: <20050708204844.7372b288@mobile.pittgoth.com> In-Reply-To: <20050708.152823.132414307.imp@bsdimp.com> References: <200507081837.j68Ib0IM082223@repoman.freebsd.org> <42CECCD8.5070201@portaone.com> <42CEEF12.4070904@samsco.org> <20050708.152823.132414307.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 08 Jul 2005 15:28:23 -0600 (MDT) "M. Warner Losh" <imp@bsdimp.com> wrote: > In message: <42CEEF12.4070904@samsco.org> > Scott Long <scottl@samsco.org> writes: > : Maxim Sobolev wrote: > : > Roman Kurakin wrote: > : > > : >> rik 2005-07-08 18:36:59 UTC > : >> > : >> FreeBSD src repository > : >> > : >> Modified files: > : >> sys/compat/ndis subr_ntoskrnl.c Log: > : >> Use implicit type cast for ->k_lock to fix compilation of ndis > : >> as a part of the GENERIC kernel with INVARIANT* and WITNESS* > : >> turned off. > : > > : > > : > I think the better fix is to change type of k_lock member from void* to > : > the struct mtx*, I've already commited such change to the RELENG_5 few > : > days ago. > : > > : > -Maxim > : > : It's a void* for portability with other OS's. This work has already > : been ported > : to Solaris, and maybe even other OS's by now. Reducing the portability is a > : bad idea, and will likely get you smacked around by Bill when he > : notices. I'd > : highly recommend not doing this again in the future. > > And once Bill gets done with you, Paul will have his turn :-) > > Warner > > (If that doesn't get me smacked, I don't know what will) > /me offers his paddle to whoever will play the punishment executioner. -- Tom Rhodes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050708204844.7372b288>