Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Sep 2007 17:00:17 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Kip Macy <kmacy@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 126330 for review
Message-ID:  <20070912150017.GA3553@garage.freebsd.pl>
In-Reply-To: <200709120832.l8C8WLlm085731@repoman.freebsd.org>
References:  <200709120832.l8C8WLlm085731@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--mYCpIKhGyMATD0i+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 12, 2007 at 08:32:21AM +0000, Kip Macy wrote:
> http://perforce.freebsd.org/chv.cgi?CH=3D126330
>=20
> Change 126330 by kmacy@kmacy_home:ethng on 2007/09/12 08:31:36
>=20
> 	convert radix node head and route locks from mutexes to rwlocks
[...]
>  		rt->rt_flags |=3D RTF_LLINFO;
> -		callout_init_mtx(&la->la_timer, &rt->rt_mtx,
> -		    CALLOUT_RETURNUNLOCKED);
> +		callout_init_rwlock(&la->la_timer, &rt->rt_lock,
> +		    CALLOUT_RETURNUNLOCKED_RW);
> =20

Kip, don't add callout_init_rwlock() to the tree. I've
callout_init_lock() implemented that operates on any lock type, just
like condvar(9).

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--mYCpIKhGyMATD0i+
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQFG5/8BForvXbEpPzQRAixrAKCmfiwWMjpEo6sak37VM3ZRtLJagwCbBjAM
hUqfYE9wrKbTDwH42CWKjFk=
=phLw
-----END PGP SIGNATURE-----

--mYCpIKhGyMATD0i+--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070912150017.GA3553>