Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 10 Nov 2014 21:13:08 +0100
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Adrian Chadd <adrian@FreeBSD.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Luigi Rizzo <rizzo@iet.unipi.it>, John Baldwin <jhb@freebsd.org>
Subject:   Re: svn commit: r273266 - in head: lib/libkvm sys/compat/freebsd32 sys/kern sys/sys
Message-ID:  <C0A6FC3B-DF34-441E-8EDD-408F61B579A9@FreeBSD.org>
In-Reply-To: <CAJ-VmomFjkw5iS51qDbG3RTVYa66FNDiSCYuX%2B-o5iGAQxzSuA@mail.gmail.com>
References:  <201410181936.s9IJaCwu018930@svn.freebsd.org> <20141019032038.GA41067@onelab2.iet.unipi.it> <CAJ-Vmo=_FkvXhyVb-WTr5NjkpTNoLv6uCtqkyc_s_2g3Z1huzw@mail.gmail.com> <CAJ-VmomxkKsogBLw7_ZeOk4%2BU8%2BjnXWYjUkaWtWteD=7S3%2BK1w@mail.gmail.com> <CAJ-VmomFjkw5iS51qDbG3RTVYa66FNDiSCYuX%2B-o5iGAQxzSuA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
I noted something similar for kgdb, when compiled with gcc:

cc1: warnings being treated as errors
/usr/src/gnu/usr.bin/gdb/kgdb/trgt_i386.c: In function 'kgdb_trgt_fetch_tss':
/usr/src/gnu/usr.bin/gdb/kgdb/trgt_i386.c:142: warning: comparison is always false due to limited range of data type

In gnu/usr.bin/gdb/kgdb/kgdb.h, there is:

struct kthr {
        struct kthr     *next;
        uintptr_t       paddr;
        uintptr_t       kaddr;
        uintptr_t       kstack;
        uintptr_t       pcb;
        int             tid;
        int             pid;
        u_char          cpu;
};

The cpu field is assigned from td.td_oncpu (which is an int) in
kgdb_thr_add_procs(), so I think it should be safe to change it to an
int too:

Index: gnu/usr.bin/gdb/kgdb/kgdb.h
===================================================================
--- gnu/usr.bin/gdb/kgdb/kgdb.h (revision 274350)
+++ gnu/usr.bin/gdb/kgdb/kgdb.h (working copy)
@@ -41,7 +41,7 @@
        uintptr_t       pcb;
        int             tid;
        int             pid;
-       u_char          cpu;
+       int             cpu;
 };

 extern struct kthr *curkthr;

-Dimitry


> On 19 Oct 2014, at 06:38, Adrian Chadd <adrian@FreeBSD.org> wrote:
> 
> Rebuilt, tested, committed to -HEAD.
> 
> Thanks!
> 
> -a
> 
> 
> On 18 October 2014 20:51, Adrian Chadd <adrian@freebsd.org> wrote:
>> .. actually, try this:
>> 
>> adrian@testbox1:~/work/freebsd/head/src % svn diff sys/kern/
>> Index: sys/kern/kern_intr.c
>> ===================================================================
>> --- sys/kern/kern_intr.c        (revision 272839)
>> +++ sys/kern/kern_intr.c        (working copy)
>> @@ -362,8 +362,7 @@
>> {
>>        struct intr_event *ie;
>>        cpuset_t *mask;
>> -       u_char cpu;
>> -       int n;
>> +       int cpu, n;
>> 
>>        mask = m;
>>        cpu = NOCPU;
>> @@ -377,7 +376,7 @@
>>                                continue;
>>                        if (cpu != NOCPU)
>>                                return (EINVAL);
>> -                       cpu = (u_char)n;
>> +                       cpu = n;
>>                }
>>        }
>>        ie = intr_lookup(irq);
>> 
>> 
>> 
>> 
>> -a
> 


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.26

iEYEARECAAYFAlRhHFoACgkQsF6jCi4glqPehgCgm902ras5wndbFy/8cQvKpkeq
ZbEAoO1cWl7EuyvQt+pEJHQUk3rAxlFi
=TYaL
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C0A6FC3B-DF34-441E-8EDD-408F61B579A9>