Date: Fri, 23 Feb 2018 22:48:59 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Konstantin Belousov <kib@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r329875 - head/sys/kern Message-ID: <YQBPR0101MB10427959074A57365EA2B4D5DDCC0@YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <201802231826.w1NIQVqr084972@repo.freebsd.org> References: <201802231826.w1NIQVqr084972@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Konstantin Belousov wrote: >Author: kib >Date: Fri Feb 23 18:26:31 2018 >New Revision: 329875 >URL: https://svnweb.freebsd.org/changeset/base/329875 > >Log: > Restore UP build. > > Reviewed by: truckman > Sponsored by: The FreeBSD Foundation > >Modified: > head/sys/kern/sched_ule.c > >Modified: head/sys/kern/sched_ule.c >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >--- head/sys/kern/sched_ule.c Fri Feb 23 18:18:42 2018 (r329874) >+++ head/sys/kern/sched_ule.c Fri Feb 23 18:26:31 2018 (r329875) >@@ -1864,6 +1864,7 @@ sched_lend_user_prio(struct thread *td, u_char prio) > td->td_flags |=3D TDF_NEEDRESCHED; > } > >+#ifdef SMP > /* > * This tdq is about to idle. Try to steal a thread from another CPU bef= ore > * choosing the idle thread. >@@ -1945,6 +1946,7 @@ tdq_trysteal(struct tdq *tdq) > } > spinlock_exit(); >} >+#endif > > /* > * Handle migration from sched_switch(). This happens only for >@@ -2058,8 +2060,10 @@ sched_switch(struct thread *td, struct thread *newt= d, > TDQ_LOCK(tdq); > mtx =3D thread_lock_block(td); > tdq_load_rem(tdq, td); >+#ifdef SMP > if (tdq->tdq_load =3D=3D 0) Since the function isn't called for UP, should this "if" also check for ncp= us > 1 by any chance? (I know nothing about ULE, so please ignore this if it doesn't make sense;-= ) > tdq_trysteal(tdq); >+#endif > } > > #if (KTR_COMPILE & KTR_SCHED) !=3D 0 rick=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YQBPR0101MB10427959074A57365EA2B4D5DDCC0>