Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Sep 2007 14:50:46 -0700
From:      "Kip Macy" <kip.macy@gmail.com>
To:        "Pawel Jakub Dawidek" <pjd@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>, Kip Macy <kmacy@freebsd.org>
Subject:   Re: PERFORCE change 126330 for review
Message-ID:  <b1fa29170709121450r5f59430bqa13373fdf807cadc@mail.gmail.com>
In-Reply-To: <20070912150017.GA3553@garage.freebsd.pl>
References:  <200709120832.l8C8WLlm085731@repoman.freebsd.org> <20070912150017.GA3553@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help
On 9/12/07, Pawel Jakub Dawidek <pjd@freebsd.org> wrote:
> On Wed, Sep 12, 2007 at 08:32:21AM +0000, Kip Macy wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=126330
> >
> > Change 126330 by kmacy@kmacy_home:ethng on 2007/09/12 08:31:36
> >
> >       convert radix node head and route locks from mutexes to rwlocks
> [...]
> >               rt->rt_flags |= RTF_LLINFO;
> > -             callout_init_mtx(&la->la_timer, &rt->rt_mtx,
> > -                 CALLOUT_RETURNUNLOCKED);
> > +             callout_init_rwlock(&la->la_timer, &rt->rt_lock,
> > +                 CALLOUT_RETURNUNLOCKED_RW);
> >
>
> Kip, don't add callout_init_rwlock() to the tree. I've
> callout_init_lock() implemented that operates on any lock type, just
> like condvar(9).

point me to a diff



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b1fa29170709121450r5f59430bqa13373fdf807cadc>