Date: Sun, 10 Jan 2016 11:58:49 -0800 From: Ravi Pokala <rpokala@mac.com> To: Sepherosa Ziehau <sepherosa@gmail.com>, Ravi Pokala <rpokala@mac.com> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Re: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth Message-ID: <E14E7F31-B49C-4BAF-AFDD-B3A5D82D9EE1@panasas.com> In-Reply-To: <CAMOc5cwZdr18AnUFoxSpONjkf9g6j5uZ-B2=YZJ%2BfzgE-4DvDA@mail.gmail.com> References: <CF7AE0AF-5471-4454-8EFF-63E31957A420@panasas.com> <CAMOc5cwZdr18AnUFoxSpONjkf9g6j5uZ-B2=YZJ%2BfzgE-4DvDA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message----- From: Sepherosa Ziehau <sepherosa@gmail.com> Date: 2016-01-10, Sunday at 00:31 To: Ravi Pokala <rpokala@mac.com> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Re: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth >On Fri, Jan 8, 2016 at 11:59 PM, Ravi Pokala <rpokala@mac.com> wrote: >> >>... >> >> Forgive me if I'm missing something obvious, but this patch doesn't actually change anything - rather than hard-coding 65535, you're using lc->lro_hiwat... which is hard-coded to 65535. >> >> Right? > >The value is intended to be changed by NIC drivers, see the code >commented out by the HN_LRO_HIWAT here: >https://reviews.freebsd.org/D4824 Cool. In that case, please mention the fact that it is currently unused when you submit the change. :-) Thanks, Ravi (rpokala@) >Thanks, >sephe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E14E7F31-B49C-4BAF-AFDD-B3A5D82D9EE1>