Date: Tue, 17 Feb 2004 03:11:10 -0800 (PST) From: Bruce Evans <bde@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/sys msgbuf.h Message-ID: <200402171111.i1HBBAZ5093340@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
bde 2004/02/17 03:11:10 PST
FreeBSD src repository
Modified files:
sys/sys msgbuf.h
Log:
Backed out previous commit since it just causes panics unless a special
value for MSGBUF_SIZE is configured. MSGBUF_SIZE =
(32768 * bootverbose ? 2 : 1) is always 1 or 2, so there is not enough space
in the buffer for metadata, and blindly using the nonexistent space tends
to cause fatal pagefaults. I think
MSGBUF_SIZE = (32768 * (bootverbose ? 2 : 1)) would be always 32768 since
bootverbose is only statically initialized to 0 early when MSGBUF_SIZE is
used. MSGBUF_SIZE = (32768 * ((boothowto & RB_VERBOSE) ? 2 : 1)) should
work, but this belongs in <sys/msgbuf.h> even less than previous versions.
MSGBUF_SIZE shouldn't be a macro.
Revision Changes Path
1.23 +1 -1 src/sys/sys/msgbuf.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402171111.i1HBBAZ5093340>