Date: Mon, 8 Oct 2007 06:57:13 GMT From: Kevin Lo <kevlo@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 127298 for review Message-ID: <200710080657.l986vDpO074738@repoman.freebsd.org>
index | next in thread | raw e-mail
http://perforce.freebsd.org/chv.cgi?CH=127298 Change 127298 by kevlo@kevlo_rtsl on 2007/10/08 06:56:52 Change bwi_stop() returns void rather than int for consistency. Affected files ... .. //depot/projects/wifi/sys/dev/bwi/if_bwi.c#3 edit Differences ... ==== //depot/projects/wifi/sys/dev/bwi/if_bwi.c#3 (text+ko) ==== @@ -114,7 +114,7 @@ static void bwi_rx_radiotap(struct bwi_softc *, struct mbuf *, struct bwi_rxbuf_hdr *, const void *, int); -static int bwi_stop(struct bwi_softc *); +static void bwi_stop(struct bwi_softc *); static int bwi_newbuf(struct bwi_softc *, int, int); static int bwi_encap(struct bwi_softc *, int, struct mbuf *, struct ieee80211_node *); @@ -1064,12 +1064,7 @@ DPRINTF(sc, "%s\n", __func__); - error = bwi_stop(sc); - if (error) { - if_printf(ifp, "can't stop\n"); - BWI_UNLOCK(sc); - return; - } + bwi_stop(sc); bwi_bbp_power_on(sc, BWI_CLOCK_MODE_FAST); @@ -1319,7 +1314,7 @@ BWI_UNLOCK(sc); } -static int +static void bwi_stop(struct bwi_softc *sc) { struct ieee80211com *ic = &sc->sc_ic; @@ -1367,8 +1362,6 @@ ifp->if_timer = 0; ifp->if_drv_flags &= ~(IFF_DRV_RUNNING | IFF_DRV_OACTIVE); BWI_UNLOCK(sc); - - return 0; } voidhelp
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710080657.l986vDpO074738>