Date: Tue, 09 Jun 2009 00:19:46 -0700 From: Xin LI <delphij@delphij.net> To: Danny Braniss <danny@cs.huji.ac.il> Cc: d@delphij.net, Hiroki Sato <hrs@FreeBSD.org>, rea-fbsd@codelabs.ru, FreeBSD Current <current@freebsd.org>, net@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sparc64 Message-ID: <4A2E0D12.40101@delphij.net> In-Reply-To: <E1MDvQt-000CEr-B0@kabab.cs.huji.ac.il> References: <20090608224516.547F17302F@freebsd-current.sentex.ca> <4A2DA390.3090704@delphij.net> <pnDviOUhM/SNuybQq0u/UHsbVeU@j4OYE6OL8eALCd4BvSxIfwgoxSc> <E1MDvQt-000CEr-B0@kabab.cs.huji.ac.il>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Danny Braniss wrote: >> Xin, good day. >> >> Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote: >>> The attached patch should fix this, any objections? >> Yes, you missed negation operator in the copyin check. The issue >> was already fixed by hrs@ two hours ago: >> http://svn.freebsd.org/viewvc/base?view=revision&revision=193796 > sorry to barge in, but: > if ((options | GIF_FULLOPTS) == GIF_FULLOPTS) > is not clear, > if ((options & ~GIF_FULLOPTS) == 0) > seems to be less offuscated or I'm missing something? Yes this looks like the usually used idiom (perhaps more efficient anyway)... I just kept the style consistent with the old code. Hiroki-san, could you have a look at this and consider if we should use this idiom? Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkouDRIACgkQi+vbBBjt66A1vACggjZwN3xCIHhfsEj141tAqqqX gdcAn0XM9BDHIhpWGct861T43SlmtQyv =ozhg -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A2E0D12.40101>