Date: Wed, 14 Dec 2005 09:10:39 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>, FreeBSD current mailing list <current@freebsd.org> Subject: Re: nve(4) patch - please test! Message-ID: <200512141710.jBEHAdZ3033442@apollo.backplane.com> References: <20051209175607.C23668@maildrop.int.zabbadoz.net> <20051210125221.M23668@maildrop.int.zabbadoz.net> <200512130031.jBD0VXih011394@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In addition to moving the nv_setmulti() and nv_ifmedia_upd() calls
to a slightly different place in DFly (after pfnInit and before pfnStart),
I also noticed that pfnStop() seems to take a flags argument which the
header files define AFFECT_RECEIVER and AFFECT_TRANSMITTER for,
but both our codes have been calling pfnStop() with a flags argument of
0.
I don't know if adding the flags has any effect but it doesn't seem to
make things worse. If pfnStop() isn't actually stopping the hardware
due to incorrect flags then all sorts of bad things can happen.
-Matt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200512141710.jBEHAdZ3033442>