Date: Mon, 04 May 2015 11:51:14 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282421 - in head: . etc Message-ID: <5547A382.6070707@FreeBSD.org> In-Reply-To: <201505041634.t44GY9OV006741@svn.freebsd.org> References: <201505041634.t44GY9OV006741@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 5/4/2015 11:34 AM, Baptiste Daroussin wrote: > Author: bapt > Date: Mon May 4 16:34:08 2015 > New Revision: 282421 > URL: https://svnweb.freebsd.org/changeset/base/282421 > > Log: > Remove now unneeded libmap32.conf This doesn't explain why; the commit message is useless. "Because r282420 ..." > > Deleted: > head/etc/libmap32.conf > Modified: > head/ObsoleteFiles.inc > head/etc/Makefile > > Modified: head/ObsoleteFiles.inc > ============================================================================== > --- head/ObsoleteFiles.inc Mon May 4 16:28:54 2015 (r282420) > +++ head/ObsoleteFiles.inc Mon May 4 16:34:08 2015 (r282421) > @@ -39,6 +39,7 @@ > # done > > # 20150504 > +OLD_FILES+=etc/libmap32.conf This seems dangerous. I think only files no longer useful in any context should be added here. A user may have their own libmap32.conf that this would remove. Mergemaster/etcupdate might handle this case fine without delete-old. There are several other bugs with libmap32.conf: There's no manpage. There's no default /usr/local/etc/libmap32.d dir or entry. -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVR6OCAAoJEDXXcbtuRpfPG+IIAKR287GRU5N+dUK2puz/LYjR l3c/+FSP5SkdO9nj8+cJGHsyWiNSB/xIVUOKAM2aQ9YOFKXVsOrIBGo0Q+/C8RXL kICMsIy24hs8NIpZ7htVDVnZVm5JNViKzppZmiglOJm/En047vzVVJCQjIE9TVfY zlbzD+i2B7AGT6qBS7z1UMw36mQiv7GPzfnn82ppIRHXCIKwSLcMxO8PajYTSD4W 55t18pLccI8pm4H9T9BPqracWNGJ5NlilztpogpLNdX5bnR0RRb82oMqnA0VJZzQ otFXfATfpaB614CJJ3dklwWwCrMc+xUo/2KaLF/0XkN9bjEL2TsDcVKugBF2U4Q= =NRBv -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5547A382.6070707>