Date: Wed, 20 Sep 2006 00:14:04 +0200 From: Marius Strobl <marius@alchemy.franken.de> To: Ruslan Ermilov <ru@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c Message-ID: <20060919221404.GT94944@alchemy.franken.de> In-Reply-To: <20060919215605.GB44298@rambler-co.ru> References: <200609191303.k8JD3AHl050783@repoman.freebsd.org> <bb4a86c70609190944o2438a4a4vae7b3bb2332522ee@mail.gmail.com> <20060919190645.GA23068@rambler-co.ru> <bb4a86c70609191236j13fe1563w123cb046261ee129@mail.gmail.com> <20060919194819.GA23360@rambler-co.ru> <bb4a86c70609191300t3bea8380qa1898d1a89b6fc27@mail.gmail.com> <20060919203608.GE23360@rambler-co.ru> <bb4a86c70609191415m59a9ef89x91f25e6912339390@mail.gmail.com> <20060919215605.GB44298@rambler-co.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 20, 2006 at 01:56:05AM +0400, Ruslan Ermilov wrote: > > The proper fix would be to fix the kernel to pass an argument by > value, like the userland does. But from the practical point of > view, it may make sense to change the API and say that these > IOCTLs now take a pointer type argument. I'm not sure. If you > know of any applications (mine test util not counting :-) that > use KDSKBMODE/KDSETLED/KDSKBSTATE, then we should probably fix > the kernel callers. XFree86/Xorg use KDSKBMODE and KDSETLED, see f.e. the Xorg "kbd" driver: http://webcvs.freedesktop.org/xorg/xserver/xorg/hw/xfree86/os-support/bsd/bsd_kbd.c?revision=1.8&view=markup Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060919221404.GT94944>