Date: Tue, 03 Oct 2000 20:48:56 +0900 (JST) From: Takahashi Yoshihiro <nyan@FreeBSD.org> To: winter@jurai.net Cc: nyan@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release/sysinstall devices.c src/sys/conf files.pc98 src/sys/dev/snc dp83932.c dp83932reg.h dp83932subr.c dp83932subr.h dp83932var.h if_snc.c if_snc_cbus.c if_snc_pccard.c if_sncreg.h if_sncvar.h src/sys/modules Makefile ... Message-ID: <20001003204856T.nyan@cc.kogakuin.ac.jp> In-Reply-To: <Pine.BSF.4.21.0010022351060.1566-100000@sasami.jurai.net> References: <200010021427.HAA16733@freefall.freebsd.org> <Pine.BSF.4.21.0010022351060.1566-100000@sasami.jurai.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <Pine.BSF.4.21.0010022351060.1566-100000@sasami.jurai.net>
"Matthew N. Dodd" <winter@jurai.net> writes:
> if_sn.c:snc_alloc_{port,memory,irq}() all need fixing in their handling of
> the failure case of bus_alloc_resource(). You can't rely on
> bus_get_resource()/bus_get_resource_start() to do the right thing if
> bus_alloc_resource() has already failed. You -must- check the return of
> bus_get_resource()/bus_get_resource_start().
>
> I'd suggest punting as the failure case only prints out a cosmetic "this
> didn't work" message.
OK, I'd fixed.
---
Takahashi Yoshihiro
The Center for Information Science, Kogakuin Univ.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001003204856T.nyan>