Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 03 Apr 2000 23:25:05 -0700
From:      Peter Wemm <peter@netplex.com.au>
To:        Gary Jennejohn <garyj@muc.de>
Cc:        Bruce Evans <bde@zeta.org.au>, freebsd-current@FreeBSD.ORG
Subject:   Re: MLEN and crashes 
Message-ID:  <20000404062505.0BE021CD7@overcee.netplex.com.au>
In-Reply-To: Message from Gary Jennejohn <garyj@peedub.muc.de>  of "Mon, 03 Apr 2000 21:32:51 %2B0200." <200004031932.VAA23846@peedub.muc.de> 

next in thread | previous in thread | raw e-mail | index | archive | help
Gary Jennejohn wrote:
> Bruce Evans writes:
> >On Mon, 3 Apr 2000, Gary Jennejohn wrote:
> >
> >> Bruce Evans writes:
> >> >On Sun, 2 Apr 2000, Gary Jennejohn wrote:
> >> >> I think we should nuke csu_hdr since it's not used anywhere. Is that
> >> >> what you really mean ?
> >> >
> >> >Yes.  I'm trying the following patch.  Only tested at compile time.
> >> >
> >> [patch snipped]
> >> 
> >> Thank you, Bruce ! This is pretty much the same patch I tested.
> >> 
> >> So, should I commit it ?
> >
> >If you have tested it :-).
> >
> 
> I'm running with the change right now. No problems.

I would prefer that we did this:

#define MAX_LEN  (min(128, MLEN))

or something like that.  This should stop Bad Things happening if
somebody recompiles with MLEN set specifically to 128 (and is an ideal
MFC candidate for 4.x for when people set MLEN to 256 over there).

Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000404062505.0BE021CD7>