Date: Mon, 10 Nov 1997 13:28:43 +0100 (MET) From: Eivind Eklund <perhaps@yes.no> To: Brian Somers <brian@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/ppp ccp.c command.c ipcp.c lcp.c lcp.h main.c modem.c modem.h os.c route.c Message-ID: <199711101228.NAA17807@bitbox.follo.net> In-Reply-To: Brian Somers's message of Fri, 7 Nov 1997 16:28:12 -0800 (PST) References: <199711080028.QAA27831@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > brian 1997/11/07 16:28:12 PST > > Modified files: > usr.sbin/ppp ccp.c command.c ipcp.c lcp.c lcp.h main.c > modem.c modem.h os.c route.c > Log: > Don't pass global vars as args. I don't think patching away that is a good idea. The goal should be to make the global variables static/local; this kind of passing should be introduced more places, not removed. Then you can make the global variable static/dynamic somewhere later. IMNSHO, Eivind.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199711101228.NAA17807>