Date: Mon, 10 Oct 2016 19:01:14 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Ruslan Bukin <br@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306964 - head/tests/sys/kern Message-ID: <20161010160114.GL68202@kib.kiev.ua> In-Reply-To: <201610101421.u9AELfwG012117@repo.freebsd.org> References: <201610101421.u9AELfwG012117@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 10, 2016 at 02:21:41PM +0000, Ruslan Bukin wrote: > Author: br > Date: Mon Oct 10 14:21:40 2016 > New Revision: 306964 > URL: https://svnweb.freebsd.org/changeset/base/306964 > > Log: > Skip test on MIPS as we don't have shared page implemented yet. > > Sponsored by: DARPA, AFRL > Sponsored by: HEIF5 > > Modified: > head/tests/sys/kern/kern_copyin.c > > Modified: head/tests/sys/kern/kern_copyin.c > ============================================================================== > --- head/tests/sys/kern/kern_copyin.c Mon Oct 10 14:21:21 2016 (r306963) > +++ head/tests/sys/kern/kern_copyin.c Mon Oct 10 14:21:40 2016 (r306964) > @@ -59,6 +59,11 @@ ATF_TC_BODY(kern_copyin, tc) > { > char template[] = "copyin.XXXXXX"; > > +#ifdef __mips__ > + /* MIPS has no shared page implemented yet. */ > + atf_tc_skip("Platform is not supported."); > +#endif > + > scratch_file = mkstemp(template); > ATF_REQUIRE(scratch_file != -1); > unlink(template); Shared page does not have much to do with the test failure. The cause is that the UVA map on mips ends the highest mapped entry at the VM_MAXUSER_ADDRESS - PAGE_SIZE, while all other arches map either stack or shared page up to the VM_MAXUSER_ADDRESS. >From the comment in mips/include/vmparam.h it is not clear whether the test could be fixed by mapping a page at VM_MAXUSER_ADDRESS - PAGE_SIZE.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161010160114.GL68202>