Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 Jul 2010 06:11:01 +0100
From:      Bruce Cran <bruce@cran.org.uk>
To:        Randi Harper <randi@FreeBSD.org>
Cc:        svn-src-head@freebsd.org
Subject:   Re: svn commit: r209782 - head/usr.sbin/sysinstall
Message-ID:  <20100708061101.00005e8b@unknown>
In-Reply-To: <201007072253.o67MrxkL028447@svn.freebsd.org>
References:  <201007072253.o67MrxkL028447@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 7 Jul 2010 22:53:59 +0000 (UTC)
Randi Harper <randi@FreeBSD.org> wrote:

> +	bzero(&server, sizeof(struct sockaddr_in));
> +	server.sin_family = AF_INET;
> +	server.sin_port = htons(514);
> +	bcopy((char *)hp->h_addr, (char *)&server.sin_addr,
> hp->h_length); +
> +	asprintf(&line, "<%d>%s", LOG_NOTICE, errstr);
> +	sendto(sock, line, strlen(line), 0, (struct sockaddr
> *)&server, 
> +	    sizeof(struct sockaddr_in));
> +

I'm wondering if server.sin_len should be set too? sendto in
uipc_syscalls.c appears to want it set (it calls sendit() which calls
getsockaddr() which gets passed mp->msg_namelen).

-- 
Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100708061101.00005e8b>