Date: Sat, 14 Jan 2017 11:44:34 +0100 From: Vincenzo Maffione <v.maffione@gmail.com> To: FreeBSD Net <freebsd-net@freebsd.org> Cc: Luigi Rizzo <rizzo@iet.unipi.it>, "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Subject: Re: powerpc.LINT* broken in netmap(4) Message-ID: <CA%2B_eA9gipfPxRVL_9O2Yuum=yv44pEEA4rrhSSjAz1zjqjYakg@mail.gmail.com> In-Reply-To: <49F36EE5-D3BD-420A-9F16-2219C7C83AC8@gmail.com> References: <D636872E-F5E0-49D4-A27E-621322BAE2CC@gmail.com> <49F36EE5-D3BD-420A-9F16-2219C7C83AC8@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2017-01-13 23:27 GMT+01:00 Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com= > : > > > On Jan 13, 2017, at 02:22, Ngie Cooper (yaneurabeya) < > yaneurabeya@gmail.com> wrote: > > > > Hi, > > I spotted these compilation errors on universe12a.freebsd.org for > both powerpc.LINT and powerpc.LINT64: > > > > cc1: warnings being treated as errors > > /scratch/tmp/ngie/svn/sys/dev/netmap/netmap_generic.c: In function > 'generic_set_tx_event': > > /scratch/tmp/ngie/svn/sys/dev/netmap/netmap_generic.c:765: warning: the > address of 'generic_mbuf_destructor' will always evaluate as 'true' > [-Waddress] > > --- netmap_generic.o --- > > *** [netmap_generic.o] Error code 1 > > > > I haven=E2=80=99t yet dug into why this only surfaces on powerpc,= yet=E2=80=A6 > > (CC -powerpc; BCC +powerpc) > Hi, > sparc64 has the same issue as powerpc*, so I suspect that gcc is > flagging this as an issue. > Thanks, > -Ngie > > PS. Sidenote: why was the SET_MBUF_DESTRUCTOR macro added, but not used i= n > nm_os_get_mbuf ? > Because the destructor is set only on certain mbufs, selected to issue notifications to netmap applications. The proper fix is probably to turn the macro to a function, I cannot think of other solutions. Cheers, Vincenzo --=20 Vincenzo Maffione
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B_eA9gipfPxRVL_9O2Yuum=yv44pEEA4rrhSSjAz1zjqjYakg>