Date: Wed, 28 Jan 2015 21:19:55 +0000 From: "hselasky (Hans Petter Selasky)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <4f6927867f192f15826ff36ed897df80@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org> References: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
hselasky added a comment.
Did you upload the correct patch?
INLINE COMMENTS
sys/kern/kern_timeout.c:674 I don't mean inside the if (c_lock != NULL) { }
There should be an else case after it.
if (c_lock != NULL) {
...
} else {
/* The callout cannot be stopped now */
cc_exec_cancel(cc, direct) = true; /* XXX this piece is missing */
}
Because else callout_stop() will return (1) when cancel() == false, which is a lie. It cannot stop the MPSAFE callout in this case and has to let it run ???
REVISION DETAIL
https://reviews.freebsd.org/D1711
To: rrs, gnn, rwatson, imp, adrian, sbruno, lstewart, hselasky
Cc: neel, erj, freebsd-net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4f6927867f192f15826ff36ed897df80>