Date: Sun, 1 Mar 2020 22:28:35 -0500 From: Ed Maste <emaste@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r358518 - head/usr.bin/elfctl Message-ID: <CAPyFy2Cbrornx_=usvrZQ8F5i9PZ%2Bn8uQYNXUwoNc9ZMgKrTiA@mail.gmail.com> In-Reply-To: <202003020422.0224Mdfa076913@repo.freebsd.org> References: <202003020422.0224Mdfa076913@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 1 Mar 2020 at 23:22, Kyle Evans <kevans@freebsd.org> wrote: > > Author: kevans > Date: Mon Mar 2 04:22:38 2020 > New Revision: 358518 > URL: https://svnweb.freebsd.org/changeset/base/358518 > > Log: > elfctl: initialize features > > GCC points out a couple levels down in convert_to_features that this may be > used uninitialized. Indeed, this is true- initialize it to NULL so that we > at least deref a null pointer. Note that features is only used in the case that editfeatures = 1, so I believe this is a false positive from GCC. But, thank you for fixing the warning / build. This code code definitely use some style(9) and tidying; I'll try to get to that shortly.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2Cbrornx_=usvrZQ8F5i9PZ%2Bn8uQYNXUwoNc9ZMgKrTiA>