Date: Wed, 28 Dec 2005 08:25:19 +0200 (EET) From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-current@freebsd.org, Norikatsu Shigemura <nork@freebsd.org> Subject: Re: vgapci doesn't want to attach agp on ASUS M5A Message-ID: <20051228075749.B57227@atlantis.atlantis.dp.ua> In-Reply-To: <200512271131.16479.jhb@freebsd.org> References: <20051225135216.Y1294@atlantis.atlantis.dp.ua> <20051226014329.152c6918.nork@FreeBSD.org> <200512271131.16479.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello! On Tue, 27 Dec 2005, John Baldwin wrote: >> I have same problem in my i830M, too and fixed Dmitry's patch. >> According to my pciconf -rb, pci_find_extcap(dev, PCIY_AGP, NULL) >> never find PCIY_AGP(because of 0x01). > > Ok. I don't see any patch anywhere, It's trivial: --- vga_pci.c.orig Thu Dec 22 18:25:22 2005 +++ vga_pci.c Sun Dec 25 13:04:09 2005 @@ -74,7 +74,7 @@ * If AGP capabilities are present on this device, then create * an AGP child. */ - if (pci_find_extcap(dev, PCIY_AGP, NULL) == 0) +// if (pci_find_extcap(dev, PCIY_AGP, NULL) == 0) device_add_child(dev, "agp", -1); > but it sounds like you'll need to fix the > DRM driver to not expect an AGP capability for this specific card or some > such. I'm not sure here. Yes, Intel's Mobile 915 PM/GM/GMS and 910GML Express Chipsets don't claim AGP capability. But they still contain AGP-related registers for compatibility. Moreover, we've just added those chipsets support to our sys/pci/agp_i810.c! So now we have an inconsistency between agp_i810.c and vga_pci.c and this should be fixed in order to get working DRM on those chipsets (people DO report that this hack makes DRM happy, I've not tried to explore it's actual functionality under XFree yet). For long-term solution, maybe we should have PCI Express-specific module which should attach to vga_pci and provide service similar to agp module. Sincerely, Dmitry -- Atlantis ISP, System Administrator e-mail: dmitry@atlantis.dp.ua nic-hdl: LYNX-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051228075749.B57227>