Date: Thu, 27 May 2010 22:12:58 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: alc@freebsd.org, Garrett Cooper <yanefbsd@gmail.com>, FreeBSD Current <freebsd-current@freebsd.org>, Alan Cox <alc@cs.rice.edu> Subject: Re: nvidia-driver 195.22 use horribly broken on amd64 between r206173 and Message-ID: <20100527191258.GQ83316@deviant.kiev.zoral.com.ua> In-Reply-To: <4BFEBFE3.9030606@FreeBSD.org> References: <AANLkTil33IEVGXxsjV1oqfBgKQq-aIJ9Ur1U0Gn8Gplt@mail.gmail.com> <4BFD4AE6.5040105@cs.rice.edu> <20100526165141.GF83316@deviant.kiev.zoral.com.ua> <4BFEBFE3.9030606@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4CM1oNDqiDLyatGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 27, 2010 at 11:54:27AM -0700, Doug Barton wrote: > On 05/26/10 09:51, Kostik Belousov wrote: > >I did a quick glance over the driver, try this: > >http://people.freebsd.org/~kib/misc/nvidia-vm_page_lock.1.patch > >I did not even compiled the patched driver. >=20 > cc -pipe -g -g -g -DNV_VERSION_STRING=3D\"195.36.15\" -D__KERNEL__ -DNVRM= =20 > -O -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I/src -I. -I@=20 > -I@/contrib/altq -finline-limit=3D8000 --param inline-unit-growth=3D100= =20 > --param large-function-growth=3D1000 -fno-common -g=20 > -mno-align-long-strings -mpreferred-stack-boundary=3D2 -mno-mmx=20 > -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector= =20 > -std=3Diso9899:1999 -fstack-protector -Wall -Wredundant-decls=20 > -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes=20 > -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign=20 > -fformat-extensions -c nvidia_subr.c > cc1: warnings being treated as errors > nvidia_subr.c: In function 'nv_alloc_system_pages': > nvidia_subr.c:1306: warning: implicit declaration of function 'vm_page_lo= ck' > nvidia_subr.c:1306: warning: nested extern declaration of 'vm_page_lock' > nvidia_subr.c:1308: warning: implicit declaration of function=20 > 'vm_page_unlock' > nvidia_subr.c:1308: warning: nested extern declaration of 'vm_page_unlock' > *** Error code 1 I think you have stale/wrong includes used by the build. I just checked that driver indeed builds with my patch. vm_page_lock() and vm_page_unlock() are the macros defined in vm/vm_page.h that are present since first Kip commit. Look at the target of the "@" symlink in the driver directory. --4CM1oNDqiDLyatGS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkv+xDoACgkQC3+MBN1Mb4ha2QCgr3XueFjnCt6Twhi7IXS+O6SV pZIAn3XdbQIIdiNV8BujFcwx98xraksl =ZTn0 -----END PGP SIGNATURE----- --4CM1oNDqiDLyatGS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100527191258.GQ83316>