Date: Wed, 1 Feb 2023 08:33:35 +0100 From: Stephane Rochoy <stephane.rochoy@stormshield.eu> To: Mitchell Horne <mhorne@freebsd.org> Cc: Stephane Rochoy <stephane.rochoy@stormshield.eu>, <freebsd-current@freebsd.org>, User Ngor <ihor@antonovs.family>, Warner Losh <imp@bsdimp.com> Subject: Re: Tooling Integration and Developer Experience Message-ID: <86y1phx2k0.fsf@cthulhu.stephaner.labo.int> In-Reply-To: <ab9eaf42-1681-0e0a-46bd-6f185bdded6a@freebsd.org> References: <202301300254.30U2sm0k061914@dell.no.berklix.net> <97020cad-f913-2985-2093-e4c23bf671e3@antonovs.family> <86357sxsly.fsf@cthulhu.stephaner.labo.int> <Y9eepV%2B%2Bch6qMBta@home.opsec.eu> <CANCZdfpPfzN%2B8nVEkRPAw2sC-W=QaUp851KcwRpJwg1zneFPNA@mail.gmail.com> <c0394d2f-6ce0-b4cd-f773-bc63073475a5@antonovs.family> <35e07b16-e635-a88c-f10b-cde0df05140b@freebsd.org> <86zg9zw0fz.fsf@cthulhu.stephaner.labo.int> <ab9eaf42-1681-0e0a-46bd-6f185bdded6a@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mitchell Horne <mhorne@freebsd.org> writes: > On 1/31/23 04:52, Stephane Rochoy wrote: >> Mitchell Horne <mhorne@freebsd.org> writes: >> >>> [Src] Needs Reviewer >>> https://reviews.freebsd.org/differential/query/65AoyPFlIhdE/ >> What is the purpose of the "Contributor Reviews (base)" >> project/group? >> Regards, >> -- St=C3=A9phane Rochoy >> O: Stormshield >> > > It is a group ("Project") that anyone can join to receive=20 > notifications whenever > the group is tagged. Groups can be added as a reviewer on a=20 > revision, for > example. > > There is a Herald rule to automatically add this Contributor=20 > Reviews group as a > subscriber to any src revisions that have no reviewers=20 > specified. > > This makes it an imperfect search criteria for "reviews which=20 > are accepted but > not authored by a FreeBSD committer". I guess the committers group was not used to let developers choose to participate or not to the "Needs Reviewer" effort. Correct? As a side note, I was surprised to see we can't query reviews from users not being in a given group, i.e., "Responsible Users" not in "Contributor Reviews (base)" would have been more straightforward. (The Project application allow advanced queries via not() and any() functions). Regards, -- St=C3=A9phane Rochoy O: Stormshield
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86y1phx2k0.fsf>