Date: Mon, 19 Jun 2023 21:46:26 -0600 From: Warner Losh <imp@bsdimp.com> To: Colin Percival <cperciva@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: b908f6c45e02 - main - bsd.mkopt.mk: Add REQUIRED_OPTIONS list Message-ID: <CANCZdfpZ4ngq61d4qqScZ3D8yPw6m099d23T2O-imbwH0GVqtQ@mail.gmail.com> In-Reply-To: <60984493-01fd-d02d-496e-1c973cdda2f7@freebsd.org> References: <202306200023.35K0NSlA057479@gitrepo.freebsd.org> <CAPyFy2AoPstPi7eMcbr3Vxp3J26QU8RrqpjP0yW2gQuDoe6z=w@mail.gmail.com> <CANCZdfpz87nXKw2-mQ0sOzW%2B%2Bv_k3_GtvVEd1vuRUTD5hNuGkQ@mail.gmail.com> <60984493-01fd-d02d-496e-1c973cdda2f7@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jun 19, 2023, 9:14 PM Colin Percival <cperciva@freebsd.org> wrote: > On 6/19/23 18:18, Warner Losh wrote: > > On Mon, Jun 19, 2023, 7:04 PM Ed Maste <emaste@freebsd.org > > <mailto:emaste@freebsd.org>> wrote: > > On Mon, 19 Jun 2023 at 20:23, Colin Percival <cperciva@freebsd.org > > <mailto:cperciva@freebsd.org>> wrote: > > > bsd.mkopt.mk <http://bsd.mkopt.mk>: Add REQUIRED_OPTIONS list > > > > > > Options on this list will be forced to 'yes'. This is > intended for use > > > as a transitional measure when an option is ceasing to be > optional, > > > before all of the associated make logic is removed. > > > > Should we emit a warning when an option is disabled in src.conf but > > specified in REQUIRED_OPTIONS? > > > > e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer > supported > > > > I asked for this in the review... I didn't approve the review because I > was > > waiting for an answer to the request. > > I'm happy to add such a warning, although I'm not sure how useful it would > be > (unless we add a 'sleep 60' afterwards perhaps?), but I don't see any such > comments on the review... did phabricator eat it? > People will see it. No sleep needed. People read the logs. Maybe I was too subtle since we went down the does := work twice... Warner -- > Colin Percival > FreeBSD Deputy Release Engineer & EC2 platform maintainer > Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 19, 2023, 9:14 PM Colin Percival <<a href="mailto:cperciva@freebsd.org" target="_blank" rel="noreferrer">cperciva@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 6/19/23 18:18, Warner Losh wrote:<br> > On Mon, Jun 19, 2023, 7:04 PM Ed Maste <<a href="mailto:emaste@freebsd.org" rel="noreferrer noreferrer" target="_blank">emaste@freebsd.org</a> <br> > <mailto:<a href="mailto:emaste@freebsd.org" rel="noreferrer noreferrer" target="_blank">emaste@freebsd.org</a>>> wrote:<br> > On Mon, 19 Jun 2023 at 20:23, Colin Percival <<a href="mailto:cperciva@freebsd.org" rel="noreferrer noreferrer" target="_blank">cperciva@freebsd.org</a><br> > <mailto:<a href="mailto:cperciva@freebsd.org" rel="noreferrer noreferrer" target="_blank">cperciva@freebsd.org</a>>> wrote:<br> > > <a href="http://bsd.mkopt.mk" rel="noreferrer noreferrer noreferrer" target="_blank">bsd.mkopt.mk</a> <<a href="http://bsd.mkopt.mk" rel="noreferrer noreferrer noreferrer" target="_blank">http://bsd.mkopt.mk</a>>: Add REQUIRED_OPTIONS list<br> > ><br> > > Options on this list will be forced to 'yes'. This is intended for use<br> > > as a transitional measure when an option is ceasing to be optional,<br> > > before all of the associated make logic is removed.<br> > <br> > Should we emit a warning when an option is disabled in src.conf but<br> > specified in REQUIRED_OPTIONS?<br> > <br> > e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer supported<br> > <br> > I asked for this in the review... I didn't approve the review because I was <br> > waiting for an answer to the request.<br> <br> I'm happy to add such a warning, although I'm not sure how useful it would be<br> (unless we add a 'sleep 60' afterwards perhaps?), but I don't see any such<br> comments on the review... did phabricator eat it?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">People will see it. No sleep needed. People read the logs.</div><div dir="auto"><br></div><div dir="auto">Maybe I was too subtle since we went down the does := work twice...</div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> -- <br> Colin Percival<br> FreeBSD Deputy Release Engineer & EC2 platform maintainer<br> Founder, Tarsnap | <a href="http://www.tarsnap.com" rel="noreferrer noreferrer noreferrer" target="_blank">www.tarsnap.com</a> | Online backups for the truly paranoid<br> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpZ4ngq61d4qqScZ3D8yPw6m099d23T2O-imbwH0GVqtQ>