Date: Wed, 14 Jul 2010 14:31:18 +0000 (UTC) From: "Justin T. Gibbs" <gibbs@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/aic7xxx aic79xx.reg aic7xxx.reg src/sys/dev/aic7xxx/aicasm aicasm_gram.y Message-ID: <201007141431.o6EEVZXe053534@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
gibbs 2010-07-14 14:31:18 UTC
FreeBSD src repository
Modified files:
sys/dev/aic7xxx aic79xx.reg aic7xxx.reg
sys/dev/aic7xxx/aicasm aicasm_gram.y
Log:
SVN rev 210055 on 2010-07-14 14:31:18Z by gibbs
Correct logic bug in aicasm's undefined register bit access detection code.
The code in question verifies that all register write operations only change
bits that are defined (in the register definition file) for that effected
register. The bug effectively disabled this checking.
o Fix the check by testing the opcode against all supported read ("and" based)
operands.
o Add missing bit definitions to the aic7xxx and aic79xx register definition
files so that the warning (treated as a fatal error) does not spuriously
fire.
Reported by: Pawel Worach <pawel.worach@gmail.com>
MFC after: 1 week
Revision Changes Path
1.20 +1 -0 src/sys/dev/aic7xxx/aic79xx.reg
1.48 +1 -0 src/sys/dev/aic7xxx/aic7xxx.reg
1.27 +10 -5 src/sys/dev/aic7xxx/aicasm/aicasm_gram.y
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007141431.o6EEVZXe053534>