Date: Sun, 29 May 2016 15:16:55 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300973 - head/usr.sbin/rpcbind Message-ID: <8A6B49EA-4551-4F7C-8332-C6E5B59A4F28@gmail.com> In-Reply-To: <9E1A1DDD-974B-481B-B659-BC099C5C0262@lists.zabbadoz.net> References: <201605292028.u4TKS1iJ017186@repo.freebsd.org> <9E1A1DDD-974B-481B-B659-BC099C5C0262@lists.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On May 29, 2016, at 14:52, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net>= wrote: >=20 >=20 >> On 29 May 2016, at 20:28 , Garrett Cooper <ngie@FreeBSD.org> wrote: >>=20 >> Author: ngie >> Date: Sun May 29 20:28:01 2016 >> New Revision: 300973 >> URL: https://svnweb.freebsd.org/changeset/base/300973 >>=20 >> Log: >> Follow up to r300932 >>=20 >> In the event MK_INET6 !=3D no in userspace, but is disabled in the >> kernel, or if there aren't any IPv6 addresses configured in userspace >> (for lo0 and all physical interfaces), rpcbind would terminate >> immediately instead of silently failing on >>=20 >> Skip over the IPv6 block to its respective cleanup with freeifaddrs if >> creating the socket failed instead of terminating rpcbind immediately >=20 > Stupid question (without me looking at the code): what does it do in case= I have no IPv4 support in the kernel anymore (as I do on some machines)? The socket call only applied to IPv6. It intentionally sets the multicast ad= dress and leaks the socket, which causes coverity to note the leak as fd is l= ocal to the function. I'll definite try out this case as well tonight.. init_transport(..) (anothe= r function in rpcbind that uses rpc(3) under the covers) was not working und= er certain edge cases with some changes I had put up for CR. I feel like I wandered into another blackberry bramble patch with rpc(3). I h= ave some ideas for refactoring rpcbind and friends to ease maintenance that I= 'll work on after 11.0-RELEASE hits. Thanks! -Ngie=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8A6B49EA-4551-4F7C-8332-C6E5B59A4F28>