Date: Tue, 15 May 2018 12:18:43 -0400 From: Mark Johnston <markj@FreeBSD.org> To: Matt Macy <mmacy@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333345 - head/sys/dev/e1000 Message-ID: <20180515161843.GA63058@raichu> In-Reply-To: <201805080139.w481djMX062724@repo.freebsd.org> References: <201805080139.w481djMX062724@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 08, 2018 at 01:39:45AM +0000, Matt Macy wrote: > Author: mmacy > Date: Tue May 8 01:39:45 2018 > New Revision: 333345 > URL: https://svnweb.freebsd.org/changeset/base/333345 > > Log: > Sleep rather than spin in e1000 when doing long running config operations. > > With r333218 it is now possible for drivers to use an sx lock and thus sleep while > waiting on long running operations rather than DELAY(). > > Reported by: gallatin > Reviewed by: sbruno > Approved by: sbruno > MFC after: 1 month > Sponsored by: Limelight Networks > Differential Revision: https://reviews.freebsd.org/D14984 This commit causes igb to fail to attach to one of the ports on an I210: igb0@pci0:5:0:0: class=0x020000 card=0x153315d9 chip=0x15338086 rev=0x03 hdr=0x00 vendor = 'Intel Corporation' device = 'I210 Gigabit Network Connection' class = network subclass = ethernet igb1@pci0:6:0:0: class=0x020000 card=0x153315d9 chip=0x15338086 rev=0x03 hdr=0x00 vendor = 'Intel Corporation' device = 'I210 Gigabit Network Connection' class = network subclass = ethernet In the dmesg I see: igb0: <Intel(R) PRO/1000 PCI-Express Network Driver> port 0xd000-0xd01f mem 0xf8300000-0xf837ffff,0xf8380000-0xf8383fff irq 18 at device 0.0 numa-domain 0 on pci6 igb0: attach_pre capping queues at 4 igb0: Setup of Shared code failed, error -2 igb0: IFDI_ATTACH_PRE failed 6 device_attach: igb0 attach returned 6 pcib7: <ACPI PCI-PCI bridge> irq 19 at device 28.3 numa-domain 0 on pci1 pci7: <ACPI PCI bus> numa-domain 0 on pcib7 igb0: <Intel(R) PRO/1000 PCI-Express Network Driver> port 0xc000-0xc01f mem 0xf8200000-0xf827ffff,0xf8280000-0xf8283fff irq 19 at device 0.0 numa-domain 0 on pci7 igb0: attach_pre capping queues at 4 igb0: using 1024 tx descriptors and 1024 rx descriptors igb0: msix_init qsets capped at 4 igb0: pxm cpus: 8 queue msgs: 4 admincnt: 1 igb0: using 4 rx queues 4 tx queues igb0: Using MSIX interrupts with 5 vectors igb0: allocated for 4 tx_queues igb0: allocated for 4 rx_queues
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180515161843.GA63058>