Date: Mon, 23 Jun 2008 09:08:20 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "QA Tindy (Ion-Mihai Tetcu)" <itetcu@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Chin-San Huang <chinsan@FreeBSD.org>, Mark Linimon <linimon@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits Makefile ports/x11-toolkits/termit Makefile distinfo pkg-descr pkg-plist pkg-plist.DOC Message-ID: <20080623090820.GA47866@FreeBSD.org> In-Reply-To: <20080621233519.6c15adc6@it.buh.tecnik93.com> References: <200806212017.m5LKHJ0B095308@repoman.freebsd.org> <20080621233519.6c15adc6@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 21, 2008 at 11:35:19PM +0300, QA Tindy (Ion-Mihai Tetcu) wrote: > On Sat, 21 Jun 2008 20:17:19 +0000 (UTC) > Chin-San Huang <chinsan@FreeBSD.org> wrote: > > > chinsan 2008-06-21 20:17:19 UTC > > > > FreeBSD ports repository > > > > Modified files: > > x11-toolkits Makefile > > Added files: > > x11-toolkits/termit Makefile distinfo pkg-descr pkg-plist > > pkg-plist.DOC > > Log: > > Small terminal emulator. The only dependencies are Vte and Gtk2 libs. > > Termit supports tabs, bookmarks, encoding switching and sessions. Pardon me, but that is terminal emulator doing in toolkits category? > > > > WWW: http://code.google.com/p/termit/wiki/TermIt > > > > Revision Changes Path > > 1.479 +1 -0 ports/x11-toolkits/Makefile > > 1.1 +54 -0 ports/x11-toolkits/termit/Makefile (new) > > 1.1 +3 -0 ports/x11-toolkits/termit/distinfo (new) > > 1.1 +4 -0 ports/x11-toolkits/termit/pkg-descr (new) > > 1.1 +7 -0 ports/x11-toolkits/termit/pkg-plist (new) > > 1.1 +4 -0 ports/x11-toolkits/termit/pkg-plist.DOC (new) It seems that you've been better off with PLIST_FILES/DIRS rather than messing with dynamic PLIST of 7+4 lines. As a side note, Makefile logic is quite hard to follow (why is do-install: needed, it is not clear up front). You've also made classic RDEPS=${BDEPS} mistake, the resulting package, for instance, would have cmake dependency in rdeps per what I see. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080623090820.GA47866>